You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trying to better understand the change. I mostly get the "expect" part, but why did it cause a change in most assertions? Does it mean we can no longer differentiate between STDERR and STDOUT with expect? (not a big deal either way).
This is minor semantics, but I'd rather we get on the same page. While we don't have formally documented coding conventions, all our test classes are public and test methods are public. Such consistency helps with IDE configuration (e.g., in Idea I can turn off "Non-public" members and still see the test methods), and just generally, with code comprehension. So let's not remove "public" with every pull request.
Trying to better understand the change. I mostly get the "expect" part, but why did it cause a change in most assertions? Does it mean we can no longer differentiate between STDERR and STDOUT with expect? (not a big deal either way).
According to pexpect docs, it only distinguishes input and output logs, which means that the kernel's stderr and stdout can only be represented as a single output stream. For testcontainers, getting stderr means getting only pexpect errors, not the kernel ones.
@m-dzianishchyts Thanks for the explanation. Another thing I noticed is the Docker scope - instead of a single container shared by all tests (static one in the superclass), it is now initialized in @BeforeAll, so each subclass calls it independently. This results in about 60% slower test run. So I wonder how essential this change is for the test stability goal?
@m-dzianishchyts Thanks for the explanation. Another thing I noticed is the Docker scope - instead of a single container shared by all tests (static one in the superclass), it is now initialized in @BeforeAll, so each subclass calls it independently. This results in about 60% slower test run. So I wonder how essential this change is for the test stability goal?
Thanks for pointing this out. It must have been left over after investigating the causes of hanging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes random hanging of integration tests.
Fixes #63.